fix(#338): Refactor OpenSettingsDialogFragment class to have a empty constructor #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethbowen
reviewed
Jun 26, 2024
src/main/java/org/medicmobile/webapp/mobile/OpenSettingsDialogFragment.java
Outdated
Show resolved
Hide resolved
garethbowen
reviewed
Jun 26, 2024
src/main/java/org/medicmobile/webapp/mobile/OpenSettingsDialogFragment.java
Show resolved
Hide resolved
m5r
approved these changes
Jun 26, 2024
tatilepizs
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #338
Refactored the
OpenSettingsDialogFragmentclass to have an empty constructor.According to the Android documentation, every
Fragmentclass should have an empty constructor that does nothing and is not a non-empty constructor. Reference. Not doing this leads to the Android ecosystem being unable to restore the Fragment's state when re-instantiated causing the issue mentioned in the linked issue.Testing:
For e2e testing, you can start using the app normally and ensure that it does not crash and to test the functionality that the
OpenSettingsDialogFragmentclass provides, you can tap the screen 5 times and then, right-swipe the screen with 2 fingers.