Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#653): add --merge-primary-contacts flag for merge-contacts action #654

Open
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

kennsippell
Copy link
Member

@kennsippell kennsippell commented Dec 9, 2024

Description

When --merge-primary-contacts is present during merge-contacts:

  • If both source and destination have a primary contact, the source primary contacts are deleted and all of their reports reassigned to the destination primary contact
  • If either source or destination don't have a primary contact, then the source primary contact is moved normally with no reports reassigned
  • If the destination has no primary contact, I considered updating the destination doc to use the source primary contact. Currently, nothing ever results in the destination contact being updated so I decided this might be overstepping.

#653

Base branch is #652

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@kennsippell kennsippell requested a review from sugat009 December 16, 2024 18:47
Base automatically changed from 650-delete-contacts to main December 16, 2024 18:50
@kennsippell
Copy link
Member Author

kennsippell commented Dec 16, 2024

One last review for these related PRs. Thanks @sugat009!

@sugat009 sugat009 self-requested a review December 18, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants