fix(#9226): fix telemetry for task refresh (#9228)

medic · Jul 2, 2024 · 53d1b21 · 53d1b21
1 parent 9f90022
commit 53d1b21
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 10 deletions.
diff --git a/webapp/src/ts/effects/reports.effects.ts b/webapp/src/ts/effects/reports.effects.ts
@@ -67,6 +67,7 @@ export class ReportsEffects {
             name: [ 'report_detail', model?.doc?.form, 'load' ].join(':'),
             recordApdex: true,
           });
+          this.trackOpenReport = null;
         }
 
         return of(this.reportActions.setRightActionBar());

diff --git a/webapp/src/ts/modules/tasks/tasks.component.ts b/webapp/src/ts/modules/tasks/tasks.component.ts
@@ -34,7 +34,8 @@ export class TasksComponent implements OnInit, OnDestroy {
   subscription = new Subscription();
   private tasksActions;
   private globalActions;
-  private trackPerformance;
+  private trackLoadPerformance;
+  private trackRefreshPerformance;
 
   tasksList;
   selectedTask;
@@ -93,7 +94,7 @@ export class TasksComponent implements OnInit, OnDestroy {
   }
 
   ngOnInit() {
-    this.trackPerformance = this.performanceService.track();
+    this.trackLoadPerformance = this.performanceService.track();
     this.tasksActions.setSelectedTask(null);
     this.subscribeToStore();
     this.subscribeToChanges();
@@ -107,7 +108,6 @@ export class TasksComponent implements OnInit, OnDestroy {
 
   ngOnDestroy() {
     this.subscription.unsubscribe();
-
     this.tasksActions.setTasksList([]);
     this.tasksActions.setTasksLoaded(false);
     this.tasksActions.setSelectedTask(null);
@@ -133,10 +133,12 @@ export class TasksComponent implements OnInit, OnDestroy {
 
   private async refreshTasks() {
     try {
+      if (this.tasksLoaded) {
+        this.trackRefreshPerformance = this.performanceService.track();
+      }
       const isEnabled = await this.rulesEngineService.isEnabled();
       this.tasksDisabled = !isEnabled;
       const taskDocs = isEnabled ? await this.rulesEngineService.fetchTaskDocsForAllContacts() : [];
-
       this.hasTasks = taskDocs.length > 0;
 
       const hydratedTasks = await this.hydrateEmissions(taskDocs) || [];
@@ -157,17 +159,28 @@ export class TasksComponent implements OnInit, OnDestroy {
       this.tasksActions.setTasksList([]);
     } finally {
       this.loading = false;
-      const performanceName = this.tasksLoaded ? 'tasks:refresh' : 'tasks:load';
-      this.trackPerformance?.stop({
-        name: performanceName,
-        recordApdex: true,
-      });
+      this.recordPerformance();
       if (!this.tasksLoaded) {
         this.tasksActions.setTasksLoaded(true);
       }
     }
   }
 
+  private recordPerformance() {
+    if (this.tasksLoaded) {
+      this.trackRefreshPerformance?.stop({
+        name: ['tasks', 'refresh'].join(':'),
+        recordApdex: true,
+      });
+      return;
+    }
+
+    this.trackLoadPerformance?.stop({
+      name: ['tasks', 'load'].join(':'),
+      recordApdex: true,
+    });
+  }
+
   listTrackBy(index, task) {
     return task?._id;
   }

diff --git a/webapp/tests/karma/ts/modules/tasks/tasks.component.spec.ts b/webapp/tests/karma/ts/modules/tasks/tasks.component.spec.ts
@@ -272,7 +272,7 @@ describe('TasksComponent', () => {
     flush();
 
     expect(rulesEngineService.fetchTaskDocsForAllContacts.callCount).to.eq(2);
-    expect(performanceService.track.calledOnce).to.be.true;
+    expect(performanceService.track.calledTwice).to.be.true;
     expect(stopPerformanceTrackStub.calledTwice).to.be.true;
     expect(stopPerformanceTrackStub.args[0][0]).to.deep.equal({ name: 'tasks:load', recordApdex: true });
     expect(stopPerformanceTrackStub.args[1][0]).to.deep.equal({ name: 'tasks:refresh', recordApdex: true });