Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#8578): update scalability suite aws image #8615

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Oct 5, 2023

Description

Old image wouldn't run apt-get update command.
Adds wait for build to be on the market, as opposed to crafting some convoluted GH actions settings (tried and didn't work) to wait for a different workflow to be successful.

#8578

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan
Copy link
Member Author

Sample scalability workflow succeeding on this branch: https://github.com/medic/cht-core/actions/runs/6417512229/job/17423423200

@dianabarsan dianabarsan requested a review from tatilepizs October 5, 2023 10:47
Copy link
Contributor

@tatilepizs tatilepizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Diana!

@dianabarsan dianabarsan merged commit fc18e30 into master Oct 5, 2023
35 of 36 checks passed
@dianabarsan dianabarsan deleted the 8578-fix-scalability-suite branch October 5, 2023 19:50
Benmuiruri pushed a commit that referenced this pull request Oct 26, 2023
Old API could run apt-get update command any more.
Adds wait for build to be on the market, as opposed to crafting some convoluted GH actions settings (tried and didn't work) to wait for a different workflow to be successful.

#8578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants