feat(#8633) accept array on schedule.start_from #8639
Conversation
| chai.expect(updWithClinic.scheduled_tasks[2]).to.deep.nested.include(expectedMessage4('scheduled')); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think we'll need to assert on the due date as well, to make sure that the correct date is picked, not just that the message gets created.
There was a problem hiding this comment.
I've verified that by calculating difference between duedate and start_date and ensuring it matches our offset here
There was a problem hiding this comment.
Yea, I mean assert on every scheduled task, maybe included the expectedMessage function?
There was a problem hiding this comment.
I was thinking about edge cases or what could go wrong. What happens if we define start_from as an array of more than two elements? What happens if every field in the start_from array is unavailable?
Does this make sense?
There was a problem hiding this comment.
Hi @lorerod , sure we can. Some of these were already in integraiton tests. I've added more tests and also added comment and made variable names more explanatory.
There was a problem hiding this comment.
Thank you, @1yuv, for this change and for adding an integration test to cover the change. This PR looks excellent!
I left a comment if it makes sense to implement an edge case. But it is definitely not a blocker.
I couldn't find any issue on cht-docs to update the schedule documentation and include this new feature. I can create one and work with you on the change.
Let me know what you think.
|
Hi @lorerod , medic/cht-docs#1207 is the releated issue for documentation update and has been approved on medic/cht-docs#1208. Also, this change required cht-conf to be updated. Related issue for cht-conf was created here and fixed by this PR. |
Description
Allow start_from on schedule to be configured using arrays as well for fixing #8633
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.