Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9238): add functionality of getting people as an AsyncGenerator in cht-datasource #9281
feat(#9238): add functionality of getting people as an AsyncGenerator in cht-datasource #9281
Changes from 54 commits
08e2b27
ab92f0b
de63197
105d5db
2b92b4c
ba2e27a
15068fa
a83a259
29a3ad5
8fbc245
a99de72
d87c258
c34716a
a9fb5eb
7b94447
4b534f3
eff3972
9a94d36
141cfab
5daa8cf
9015353
8be7b70
54da9fb
6064c99
9fb6c7b
2364d82
1b87d4a
9a828a6
cd81f2d
cd344d5
5d7fc98
4279c60
190f69e
cb34075
154b295
c233d0b
a9cf536
318c1a4
bc92ff3
0e6e9ea
d14ce9e
36a5a87
d87d293
2867a80
84c30c9
d45f0d9
563ac81
fd72695
bab3c1e
0d305ff
15b6e39
1d62657
1057fe4
88f39d7
60604a5
3eeb049
7e0355f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know that we have reached the end of the results, we should not return a cursor value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I believe
cursor
's type should beThat's more explicit to express "you've reached the end"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be more explicit and return
"-1"
and not nothing to indicate the end of iteration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m5r and I commented simultaneously,
null
should do as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid logic here! 👍 I think we can tighten up the cursor calculation a bit (at least reduce the nesting if-statements):