chore(#9233): clean up and organize e2e tests: folder /upgrade #9289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatilepizs
requested changes
Aug 1, 2024
There was a problem hiding this comment.
It looks really good @lorerod, thank you 🌟
I just left a couple of suggestions
Comment on lines
6
to
12
| const adminUser = { | ||
| username: 'admin2', | ||
| password: 'medic.123', | ||
| roles: [ 'admin' ], | ||
| roles: ['admin'], | ||
| contact: { name: 'Philip' }, | ||
| place: { name: 'place', type: 'district_hospital' }, | ||
| }; |
There was a problem hiding this comment.
Please use factory to create the user.
It can be like this:
const adminUser = userFactory.build({
roles: ['admin'],
contact: { name: 'Philip' },
place: { name: 'place', type: 'district_hospital' },
});
tatilepizs
approved these changes
Aug 6, 2024
Co-authored-by: Tatiana Lépiz Soto <[email protected]>
Co-authored-by: Tatiana Lépiz Soto <[email protected]>
lorerod
force-pushed
the
9233-clean-up-and-organize-upgrade-e2e-folder
branch
from
16773a9 to
87253e8
Compare
sugat009
pushed a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Maria Lorena Rodriguez Viruel <[email protected]> Co-authored-by: Tatiana Lépiz Soto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9233
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.