Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#9241): create REST API endpoint for getting people #9295

Merged
merged 66 commits into from
Aug 12, 2024
Merged

feat(#9241): create REST API endpoint for getting people #9295

merged 66 commits into from
Aug 12, 2024

Conversation

sugat009
Copy link
Member

@sugat009 sugat009 commented Aug 1, 2024 •
edited
Loading

Description

Add a new REST API endpoint that gets people using cht-datasource.

Ticket: #9241

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

sugat009 and others added 20 commits July 16, 2024 14:27
@sugat009
feat(#9237): Add functionality of getting people with pagination in c…
08e2b27 
…ht-datasource
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/local/libs/doc.ts
ab92f0b 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009
feat(#9237): Address PR comments
de63197
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/qualifier.ts
105d5db 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/test/local/person.spec.ts
2b92b4c 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/person.ts
ba2e27a 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/remote/person.ts
15068fa 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/person.ts
a83a259 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/index.ts
29a3ad5 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009
feat(#9237): Address PR comments
8fbc245
@sugat009
feat(#9237): Add unit tests for getResources in remote mode
a99de72
@sugat009
feat(#9237): Address PR comments
d87c258
@sugat009
(#feat): Minor fix
eceeb75
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/person.ts
1aab0e3 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/test/local/libs/lineage.spec.ts
54d04cb 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/test/local/libs/lineage.spec.ts
dcc3758 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/test/local/person.spec.ts
e800b1a 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009
feat(#9237): Address PR comments
34b466c
@sugat009
feat(#9241): add REST endpoint /api/v1/people to get people
3aa0fd8
@sugat009
feat(#9241): Add unit tests for controller
f47b819
@sugat009 sugat009 added the Type: Feature Add something new label Aug 1, 2024
@sugat009 sugat009 requested review from jkuester and m5r August 1, 2024 11:26
@sugat009 sugat009 self-assigned this Aug 1, 2024
m5r
m5r suggested changes Aug 1, 2024
View reviewed changes
shared-libs/cht-datasource/src/libs/error.ts Outdated Show resolved Hide resolved
shared-libs/cht-datasource/src/libs/error.ts Outdated Show resolved Hide resolved
api/tests/mocha/controllers/person.spec.js Show resolved Hide resolved
api/tests/mocha/controllers/person.spec.js Show resolved Hide resolved
sugat009 and others added 24 commits August 8, 2024 18:11
@sugat009
Fix conflict with target branch
cbfb30f
@sugat009 @m5r
Update shared-libs/cht-datasource/src/person.ts
1704024 
Co-authored-by: Mokhtar <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/index.ts
a73932e 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/index.ts
711748d 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/person.ts
ff9bd08 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009
Remove limit and skip as arguments for getDocumentStream function
cb7cf93
@sugat009
Remove duplicate test case added during conflict resolution
9625fc6
@sugat009
Cleanup after refactoring
820bb48
@sugat009
Fix unit tests according to implementation of cursor pagination
5656f0a
@sugat009
Add unit tests
90cc788
@sugat009
Address PR comments
6d5f2dd
@sugat009
Avoid using spread operator in getDocumentStream function
8c77a08
@sugat009
Fix conflict with target branch
315fff9
@sugat009
Remove limit and skip as arguments for getDocumentStream function
507e63f
@sugat009
Cleanup after refactoring
7f6e7b9
@sugat009
Refactor getDocumentStream w.r.t. the cursor based pagination in getP…
74e3600 
…ageByType
@sugat009
Fix merge conflicts with target branch
036ce01
@sugat009 @jkuester
Update shared-libs/cht-datasource/src/libs/core.ts
b5efcda 
Co-authored-by: Joshua Kuestersteffen <[email protected]>
@sugat009
Change skip to cursor in all places and refactor fetchAndFilter funct…
7914acd 
…ion in local/person.ts
@sugat009
Fix eslint issues
c79c935
@sugat009
feat(#9241): add REST endpoint /api/v1/people to get people
ae39df7
@sugat009
Add integration tests to the /api/v1/person route and fix some issues
d8d072c
@sugat009
Address PR comments
3e651e8
@sugat009
Fix conflict with main and change skip to cursor in endpoint
dd4b59a
@sugat009 sugat009 requested a review from jkuester August 8, 2024 14:00
Base automatically changed from 9237-add-functionality-of-getting-people-with-pagination-in-cht-datasource to 9193-api-endpoints-for-getting-contacts-by-type August 9, 2024 13:33
@sugat009
Merge remote-tracking branch 'origin/9193-api-endpoints-for-getting-c…
bdf5ee2 
…ontacts-by-type' into 9241-create-api-endpoint-for-getting-people
@sugat009 sugat009 merged commit 20ee6e5 into 9193-api-endpoints-for-getting-contacts-by-type Aug 12, 2024
18 of 20 checks passed
@sugat009 sugat009 deleted the 9241-create-api-endpoint-for-getting-people branch August 12, 2024 12:38
@sugat009 sugat009 mentioned this pull request Dec 5, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m5r m5r m5r approved these changes

@jkuester jkuester Awaiting requested review from jkuester

Assignees

@sugat009 sugat009

Labels
Type: Feature Add something new
Projects
No open projects
Product Team Activities
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sugat009 @jkuester @m5r