feat(#9362): publish cht-deploy to npm on version change

[henokgetachew]

Description

Publishes to npm on version change in cht-deploy package.json (Under scripts/deploy/). The version change has to happen manually and no automated commits to github happens. This was done on purpose, to avoid triggering the build process. It runs the cht-deploy tests to make sure they pass before publishing.

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.

Compose URLs

If Build CI hasn't passed, these may 404:

• Core
• CouchDB Single
• CouchDB Cluster

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[garethbowen]

A couple of questions inline.

I'm assuming you haven't tested this at all, because it only runs on master? What do you think about tweaking it slightly so we can run it in this branch and check if it actually works and then switch back to master before merging?

For example, it would be good to check that, a) it actually builds and publishes correctly, and 2) it doesn't publish if it's run a second time and the version hasn't changed.

Otherwise we might end up cluttering up the commit log trying to get this to work in master.

[garethbowen]

In cht-conf we use semantic release to do this and it would be great to use the same in both places, but that library is designed to also update the version and generate release notes so maybe it's overkill. What do you think?

[henokgetachew]

Yes, semantic release is cool and more comprehensive. I liked the automated changelog.md. I was assuming that it would try to include all the CHT related commits in the release notes. That may not be the case.. If that's not the case, there is a commits analyzer to filter out commits that don't have anything to do with cht-deploy. I'll give it a look.

[henokgetachew]

Thanks @garethbowen!

Current state of things:

• We're using semantic-release
• The workflow triggers only on changes to the scripts/deploy/** path.
• If the branch is master, it doesn't run the tests.
• If the branch is any other branch, it runs the tests and it makes a pre-release to npm

We need to configure secrets - I don't have those rights on this repo:

          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

That's what's remaining to see this in action.

[garethbowen]

Nice one! A couple changes suggested, and I'll look at getting the tokens added.

[garethbowen]

I suspect this won't work as expected because it'll get the changelog for all commits on the master branch, not just commits that impact this directory. What do you think?

[garethbowen]

Once we merge this check should be at the top level instead of here because the entire publish job should not run if not on master, right?

[henokgetachew]

Closing this in favor of moving cht-deploy to its own repo.