fix(#9341): strip invisible characters

[aloundoye]

Description

fix #9341

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Documented: Configuration and user documentation on cht-docs
• Tested: Unit and/or e2e where appropriate
• Internationalised: All user facing text
• Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[aloundoye]

@garethbowen, can you look at this one?

[garethbowen]

Thanks, this looks good to me!

Can you please also add few unit tests to prove that this works as expected. One technique I like to use is red/green testing which means you write the test which is failing, and then write the code to solve it, and see that the test goes green. Because you've already written the code I recommend commenting it out, and writing the test, and then uncommenting the code again. This gives me a lot of confidence that I've actually solved the issue.

The best place to put these unit tests is smsparser.spec.js

[garethbowen]

I didn't realise this function wasn't tested at all! Thank you for filling that hole in the coverage.

Can you add one more test which tests that invisible characters are stripped? For example, copy one of the tests you added and add an invisible character to the input string?

[garethbowen]

Excellent! Thanks for the quick turnaround.

I'll merge this as soon as the build passes.

[aloundoye]

I'll merge this as soon as the build passes.

Thanks @garethbowen