Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(#9642): set changes_doc_ids_optimization_threshold a high value #9651

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Nov 15, 2024

Description

It appears that changes_doc_ids_optimization_threshold is still working and will provide us the same performance we had before.

#9642

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan dianabarsan requested a review from sugat009 November 15, 2024 17:16
@dianabarsan
Copy link
Member Author

Hi @sugat009
Would you mind running this branch and time purging on your test instance? Thanks!!

@dianabarsan dianabarsan added this to the 4.15.0 milestone Nov 16, 2024
@sugat009
Copy link
Member

@dianabarsan The purge has been completed using this branch. It took 47.108 minutes for the same amount of docs as in #9303 .

@dianabarsan
Copy link
Member Author

Ok, this is first time purging or second time? It doesn't really matter, but we're in the ballpark. I think Couch 3.3 time was 60 min right?

Then we'll go with this one.

@sugat009
Copy link
Member

yes, for couch 3.3.3 was ~60 mins.

@dianabarsan dianabarsan removed this from the 4.15.0 milestone Nov 18, 2024
@dianabarsan dianabarsan merged commit 5d4634a into master Nov 26, 2024
47 checks passed
@dianabarsan dianabarsan deleted the 9642-purging-without-changes-2 branch November 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants