Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9686): require valid input on core version in docker helper #9687

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

mrjones-plip
Copy link
Contributor

@mrjones-plip mrjones-plip commented Dec 3, 2024

Description

This PR adds a valid input checker on core version in docker helper:

Screencast.from.2024-12-03.10-18-25.webm

closes #9686

Testing

  1. Ensure existing docker helper projects can launch
  2. Ensure new docker helper project can be created on latest version without selecting a specific version
  3. Ensure new docker helper project can be created on specific version using new select logic

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@mrjones-plip mrjones-plip requested a review from sugat009 December 3, 2024 18:16
@mrjones-plip mrjones-plip requested a review from sugat009 December 4, 2024 03:39
@mrjones-plip mrjones-plip merged commit 0e548d2 into master Dec 4, 2024
46 checks passed
@mrjones-plip mrjones-plip deleted the validate-docker-helper-version branch December 4, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate CHT Version on Docker Helper
2 participants