-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9683): add Arabic translations #9696
Conversation
@m5r These are the Arabic translations shared by ICRC. I took a shot at creating the 1.mp4 |
@andrablaj yes the words appear to be in correct order 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't help much with the translations specifically but on the implementation side, I believe you missed those files:
https://github.com/medic/cht-core/blob/9683-add-arabic/webapp/src/js/bootstrapper/translator.js
https://github.com/medic/cht-core/blob/9683-add-arabic/webapp/src/js/enketo/main.js
@m5r would you please look at the newer version of this PR? For the webapp/src/js/bootstrapper/translator.js file, I used some translations from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, well done 🙌
Description
Add Arabic translations (see translation file).
Closes #9683
Code review checklist
can_view_old_navigation
permission to see the old design.Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.