Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#6250): remove request-promise-native from e2e tests #9703

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Dec 11, 2024

Description

Updates e2e tests request to use built-in fetch instead of request-promise-native.
Removes sessions from e2e tests, these are not needed anymore.
Updates all (except 2) datasource e2e tests to query api directly. These tests required that global fetch had a session enabled to work, and stopped working once sessions were removed.

#6250

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan dianabarsan marked this pull request as ready for review December 12, 2024 12:03
@dianabarsan dianabarsan requested a review from sugat009 December 12, 2024 12:26
Copy link
Member

@sugat009 sugat009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@dianabarsan dianabarsan merged commit 58a5e7d into master Dec 13, 2024
47 checks passed
@dianabarsan dianabarsan deleted the 6250-use-fetch-in-tests branch December 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants