Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9704): throw pouch errors when saving target docs #9705

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(#9704): throw pouch errors when saving target docs #9705

merged 1 commit into from
Dec 17, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Dec 12, 2024 •
edited by github-actions bot
Loading

Description

#9704

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan dianabarsan force-pushed the 9704-throw-pouch-errors branch from fdcd765 to 10748a8 Compare December 12, 2024 12:34
@dianabarsan dianabarsan marked this pull request as ready for review December 12, 2024 13:45
@dianabarsan dianabarsan requested a review from jkuester December 12, 2024 13:47
jkuester
jkuester approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@dianabarsan dianabarsan merged commit 0738e80 into master Dec 17, 2024
46 checks passed
@dianabarsan dianabarsan deleted the 9704-throw-pouch-errors branch December 17, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkuester jkuester jkuester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianabarsan @jkuester