Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#8626): display SVG icons in contact summary #9719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Dec 18, 2024

Description

The SVG was added to the HMTL correctly; it needed a CSS fix.

Test video:
https://github.com/user-attachments/assets/4c233b66-af4a-4871-b3f4-7cb1e48d3c4b

#8626

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda requested a review from jkuester December 18, 2024 16:27
@latin-panda latin-panda linked an issue Dec 18, 2024 that may be closed by this pull request
@latin-panda
Copy link
Contributor Author

@jkuester this is ready for review. It's small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact summary page doesn't support svg icons
1 participant