Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#620): move cht-conf readme file #1451

Merged
merged 12 commits into from
Jul 23, 2024
Merged

Conversation

tatilepizs
Copy link
Contributor

Description

Move the cht-conf README file in a new section on the Contributor Handbook

cht-conf #620

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@tatilepizs tatilepizs requested a review from esthermmoturi July 11, 2024 22:36
content/en/contribute/code/conf/_index.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/installation.md Outdated Show resolved Hide resolved
linkTitle: "Development"
weight: 1
description: >
To develop a new action or improve an existing one, check the ["Actions" doc](https://github.com/medic/cht-conf/blob/main/src/fn/README.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tatilepizs , how can we describe 'Actions'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t really know 🫣
@m5r, @jkuester do you know?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An action is a command that's part of cht-conf, that you may execute against a CHT instance (hence the requiresInstance field mentioned in that readme). It's invoked by app developers by running cht-conf <action-name> and they can be chained cht-conf <action-1> <action-2> <action-3>.
Each .js file in cht-conf/src/fn is an action.

content/en/contribute/code/conf/fetching-logs.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/project-layout.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/currently-supported.md Outdated Show resolved Hide resolved
@tatilepizs tatilepizs requested a review from esthermmoturi July 15, 2024 20:05
content/en/contribute/code/conf/currently-supported.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/currently-supported.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/development.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/fetching-logs.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/installation.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/installation.md Outdated Show resolved Hide resolved
content/en/contribute/code/conf/project-layout.md Outdated Show resolved Hide resolved
@tatilepizs
Copy link
Contributor Author

@esthermmoturi, @jkuester , @m5r thank you all for your review and help to make this document better. ⭐

One thing that I am not clear about is the location, should I move all those files related to cht-conf to core/overview? Or just currently-supported.md and project-layout.md?

@jkuester
Copy link
Contributor

My vote is we keep things simple here initially and start with only adding two pages:

  • core/overview/cht-conf - this should have content relevant to users of cht-conf
  • contribute/code/cht-conf - this should have content relevant to developers/contributors to the cht-conf code

Later we can expand these pages to multiple sub-pages, etc as needed.

@tatilepizs
Copy link
Contributor Author

Thanks @jkuester.

I like the idea of keeping it simple for now.
Let me try it to see how it looks 🙂

@tatilepizs
Copy link
Contributor Author

I'm sorry if this is confusing 😅 now we have only two new files. How does it look?

@tatilepizs tatilepizs requested a review from esthermmoturi July 17, 2024 14:26
Copy link
Contributor

@esthermmoturi esthermmoturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tatilepizs tatilepizs merged commit 15d06ea into main Jul 23, 2024
2 checks passed
@tatilepizs tatilepizs deleted the move-cht-conf-readme-file branch July 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants