Simplified success messaging

medic · Dec 20, 2024 · 0ccd7c8 · 0ccd7c8
1 parent a195626
commit 0ccd7c8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/src/lib/manage-hierarchy.ts b/src/lib/manage-hierarchy.ts
@@ -29,10 +29,6 @@ export default class ManageHierarchyLib {
 
   public static async scheduleJob(job: JobParams, queueName: IQueue = getChtConfQueue()) {
     await queueName.add(job);
-
-    return {
-      success: true
-    };
   }
 
   public static parseHierarchyAction(action: string = ''): HierarchyAction {

diff --git a/src/routes/manage-hierarchy.ts b/src/routes/manage-hierarchy.ts
@@ -46,8 +46,8 @@ export default async function sessionCache(fastify: FastifyInstance) {
       const isConfirmed = formData.confirmed === 'true';
       const job = await ManageHierarchyLib.getJobDetails(formData, contactType, sessionCache, chtApi);
       if (isConfirmed) {
-        const result = await ManageHierarchyLib.scheduleJob(job);
-        tmplData.success = result.success;
+        await ManageHierarchyLib.scheduleJob(job);
+        tmplData.success = true;
       } else {
         const warningInfo = await ManageHierarchyLib.getWarningInfo(job, chtApi);
         tmplData.warningInfo = warningInfo;

diff --git a/test/lib/manage-hierarchy.spec.ts b/test/lib/manage-hierarchy.spec.ts
@@ -58,11 +58,6 @@ describe('lib/manage-hierarchy.ts', () => {
         instanceUrl: 'http://domain.com',
         sessionToken: 'encoded-token',
       });
-
-      const actual = await ManageHierarchyLib.scheduleJob(jobParams, chtConfQueue);
-
-      // Verify the data passed to mockmoveContactQueue
-      expect(chtConfQueue.add.calledOnce).to.be.true;
     });
 
     it('move CHU: subcounty required', async () => {
@@ -128,9 +123,6 @@ describe('lib/manage-hierarchy.ts', () => {
         instanceUrl: 'http://domain.com',
         sessionToken: 'encoded-token',
       });
-
-      await ManageHierarchyLib.scheduleJob(jobParams, chtConfQueue);
-      expect(chtConfQueue.add.calledOnce).to.be.true;
     });
   });