Paul code review feedback

src/config/config-worker.ts

@@ -11,7 +11,7 @@ export const WorkerConfig = {
     host: environment.REDIS_HOST,
     port: Number(environment.REDIS_PORT),
   },
-  moveContactQueue: 'MOVE_CONTACT_QUEUE',
+  chtConfQueueName: 'MOVE_CONTACT_QUEUE',
   defaultJobOptions: {
     attempts: 3, // Max retries for a failed job
     backoff: {

src/lib/queues.ts

@@ -36,7 +36,7 @@ export class BullQueue implements IQueue {
 }
 
 export const getChtConfQueue = () => new BullQueue(
-  WorkerConfig.moveContactQueue, 
+  WorkerConfig.chtConfQueueName, 
   WorkerConfig.redisConnection,
   WorkerConfig.defaultJobOptions
 );

src/liquid/place/manage_hierarchy_form.html

@@ -73,7 +73,7 @@ <h1 class="subtitle">{{ destinationDescription }}</h1>
         pauseOnHover: true,
         type: 'is-success',
         position: 'top-center',
-        message: `<p>Operation has been scheduled. Please allow up to 24 hours for processing.</p>`,
+        message: `<p>{{ op | capitalize }} operation scheduled. Please allow up to 24 hours for processing.</p>`,
       });
     }
   }

src/worker/cht-conf-worker.ts

@@ -58,7 +58,7 @@ export class ChtConfWorker {
       throw new DelayedError();
     }
 
-    const result = await this.moveContact(job);
+    const result = await this.processChtConfJob(job);
     if (!result.success) {
       const errorMessage = `Job ${job.id} failed with the following error: ${result.message}`;
       console.error(errorMessage);
@@ -109,7 +109,7 @@ export class ChtConfWorker {
     return axios.get(`${instanceUrl}/api/v2/monitoring`);
   }
 
-  private static async moveContact(job: Job): Promise<JobResult> {
+  private static async processChtConfJob(job: Job): Promise<JobResult> {
     try {
       const jobData: ChtConfJobData = job.data;
 

src/worker/main.ts

@@ -6,10 +6,10 @@ import { ChtConfWorker } from './cht-conf-worker';
 import { WorkerConfig, checkRedisConnection } from '../config/config-worker';
 
 (async () => {
-  const { moveContactQueue, redisConnection} = WorkerConfig;
+  const { chtConfQueueName, redisConnection } = WorkerConfig;
   await checkRedisConnection();
   ChtConfWorker.processQueue(
-    moveContactQueue, 
+    chtConfQueueName, 
     redisConnection
   );
   console.log(`🚀 CHT Conf Worker is listening`);