-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gender form input should be a dropdown instead of freetext field #55
Comments
I propose removing this type and replacing it with a select_one type. This not only addresses the gender issue but also enables the selected items to be transformed into a dropdown. The parameter will be an object with key = select-option value and value = label. |
Sounds good @inromualdo! Interested to learn which of these tests will work after the change. If we break a few, I think that'd be okay - let's just be clear on what the new This may also be useful for @paulpascal to address this feedback. |
@inromualdo , we will have |
How many levels of study are there? Interested in why you're thinking a csv is needed here since parameter already supports
Gender supports some weird cases like mapping |
This is just an example. Here, there is 5. But in the CIV project we have a select_one with more than 200 items.
In this example, I use object, so that I can display a friendly label
Those would be handled. |
* feat(#55): add select_one and select_multiple * feat(#55): remove gender validator file * feat(#55): update readme * fix(#55): address feedback * fix(#55): address feedback part 2 * test(#55): update test cases * fix(#55): address feedback part 3 * fix(#55): address final feedback * 1.3.5 --------- Co-authored-by: Kenn Sippell <[email protected]> Co-authored-by: paulpascal <[email protected]>
#40 (comment)
The text was updated successfully, but these errors were encountered: