Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add select_one and select_multiple types #96

Merged
merged 13 commits into from
Mar 29, 2024
Merged

Add select_one and select_multiple types #96

merged 13 commits into from
Mar 29, 2024

Conversation

inromualdo
Copy link
Contributor

@inromualdo inromualdo commented Mar 14, 2024 •
edited
Loading

fix #55

@inromualdo inromualdo requested a review from kennsippell March 14, 2024 00:31
@inromualdo inromualdo changed the title feat(#55): add select_one and select_multiple Add select_one and select_multiple types Mar 14, 2024
kennsippell
kennsippell requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@kennsippell kennsippell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee!!!!

src/lib/validator-regex.ts Show resolved Hide resolved
src/config/index.ts Show resolved Hide resolved
src/lib/validator-select_multiple.ts Outdated Show resolved Hide resolved
src/lib/validator-select_multiple.ts Outdated Show resolved Hide resolved
src/lib/validator-select_multiple.ts Outdated Show resolved Hide resolved
src/liquid/components/list_cell.html Outdated Show resolved Hide resolved
test/lib/validation.spec.ts Outdated Show resolved Hide resolved
test/lib/validation.spec.ts Outdated Show resolved Hide resolved
test/lib/validation.spec.ts Outdated Show resolved Hide resolved
test/lib/validation.spec.ts Outdated Show resolved Hide resolved
kennsippell
kennsippell reviewed Mar 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@kennsippell
Copy link
Member

Can we match column width?
image

@paulpascal
Copy link
Contributor

Hello @kennsippell, I have addressed your feedback. Would you like to check it back?

Thanks

@kennsippell kennsippell self-requested a review March 27, 2024 16:40
@kennsippell
Copy link
Member

@paulpascal I'll review this again tomorrow night. Sorry for the delay.

@paulpascal
Copy link
Contributor

Thanks 😊

kennsippell
kennsippell requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@kennsippell kennsippell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close!!

README.md Outdated Show resolved Hide resolved
src/config/index.ts Outdated Show resolved Hide resolved
src/lib/validation.ts Outdated Show resolved Hide resolved
src/liquid/components/contact_type_property.html Show resolved Hide resolved
src/lib/validator-select_multiple.ts Outdated Show resolved Hide resolved
src/lib/validator-select_multiple.ts Outdated Show resolved Hide resolved
src/lib/validator-regex.ts Show resolved Hide resolved
@paulpascal paulpascal requested a review from kennsippell March 29, 2024 11:22
@paulpascal
Copy link
Contributor

Thanks @kennsippell , for this great review again.
I have addressed them.

kennsippell
kennsippell approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@kennsippell kennsippell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!!

src/config/chis-tg/config.json Show resolved Hide resolved
src/lib/validation.ts Outdated Show resolved Hide resolved
src/lib/validator-name.ts Outdated Show resolved Hide resolved
src/lib/validator-select_multiple.ts Outdated Show resolved Hide resolved
src/config/index.ts Outdated Show resolved Hide resolved
@paulpascal paulpascal merged commit ef9f593 into main Mar 29, 2024
1 check passed
@paulpascal paulpascal deleted the 55_select branch March 29, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpascal paulpascal paulpascal left review comments

@kennsippell kennsippell kennsippell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gender form input should be a dropdown instead of freetext field
3 participants
@inromualdo @kennsippell @paulpascal