UI improvements - forms #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
freddieptf
requested changes
May 16, 2024
src/liquid/place/create_form.html
Outdated
| </div> | ||
| <div class=""> | ||
| <button id="place_create_submit" class="btn">Save</button> | ||
| <a href="/" class="clear-btn" class="button">Cancel</a> |
There was a problem hiding this comment.
Do we have both a btn and button class? Also the Save button casts a shadow but the cancel one doesn't even though they should be visually on the save level
src/scss/_input-forms.scss
Outdated
| padding: 5px 10px; | ||
| cursor: pointer; | ||
| &:hover { | ||
| background-color: #337ab7; |
There was a problem hiding this comment.
This color is too strong for the hover state
| <td>false</td> | ||
| <td>Name of a <i>{{ contactType.friendly }} to replace</i> (leave blank to create new)</td> | ||
| </tr> | ||
| <div style="width: 70%; margin-bottom: 10px;" id="bulk-upload-file"> |
There was a problem hiding this comment.
Lets not use inline styles like this
| </div> | ||
| <div> | ||
| <button id="place_create_submit" class="btn">Add</button> | ||
| <a href="/" id="cancel" class="clear-btn">Cancel</a> |
There was a problem hiding this comment.
These two buttons should be on the same visual level but use the of class btn adds a shadow to the Add button
| <td>Name of place {{ row.level }} above in hierarchy</td> | ||
| </tr> | ||
| {% endfor %} | ||
| <div class="table-container"> |
There was a problem hiding this comment.
We can do without the shadow on this table
jonathanbataire
force-pushed
the
131-main-ui
branch
from
c67e457 to
c36c9c9
Compare
jonathanbataire
force-pushed
the
131-forms-ui
branch
from
06f5d90 to
7baca43
Compare
|
@freddieptf this is ready for review |
|
@freddieptf requesting review here this is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is 3/3 of #168 and #157
Fixes #131