Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally enable/disable features on contact types #227

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

freddieptf
Copy link
Collaborator

@freddieptf freddieptf commented Nov 19, 2024

This PR introduces a way to explicitly enable/disable the main 3 features of this app i.e creating places, replacing contacts and moving places. This came from this request where users need to be allowed to move households but not create/replace. All features are enabled by default but this can be configured using the feature_flags field.

@freddieptf freddieptf marked this pull request as ready for review November 19, 2024 17:11
Copy link
Contributor

@paulpascal paulpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @freddieptf 🍞

I left some little feedback inline

src/config/chis-ke/config.json Show resolved Hide resolved
src/config/index.ts Outdated Show resolved Hide resolved
src/config/config-factory.ts Outdated Show resolved Hide resolved
src/config/index.ts Outdated Show resolved Hide resolved
src/lib/remote-place-resolver.ts Outdated Show resolved Hide resolved
@kennsippell
Copy link
Member

Have you tried this change on production data like the Nairobi instance. It will download and cache every household... Does it just explode?

@freddieptf
Copy link
Collaborator Author

freddieptf commented Nov 26, 2024

I tried it on production and the request never completed so we can't actually search for households this way. Not sure if using the contacts_by_parent view will help resolve the places faster

@freddieptf freddieptf mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants