Show an informational warning before performing hierarchy operations #233
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/liquid/components/manage_hierarchy_warning.html: Language not supported
- src/liquid/place/manage_hierarchy_form.html: Language not supported
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/liquid/components/manage_hierarchy_warning.html: Language not supported
- src/liquid/place/manage_hierarchy_form.html: Language not supported
Comments suppressed due to low confidence (2)
src/lib/manage-hierarchy.ts:88
- [nitpick] The
describeDateTimefunction returns a hyphen ('-') for invalid or negative dates, which might be confusing.
return '-';
src/lib/manage-hierarchy.ts:67
- [nitpick] The variable name
syncBelowThresholdis ambiguous and could be more descriptive.
userIsActive: syncBelowThreshold && lastSyncDescription !== '-';
| jobData, | ||
| }; | ||
| function diffNowInDays(dateTime: DateTime): number { | ||
| return -(dateTime?.diffNow('days')?.days || 0); |
There was a problem hiding this comment.
The diffNowInDays function returns negative values, which is counterintuitive. It should return positive values for days in the past and zero or more for future dates.
| return -(dateTime?.diffNow('days')?.days || 0); | |
| return dateTime?.diffNow('days')?.days || 0; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Actually the Luxon library's DateTime.diffNow function returns negatives and that negative makes them positive
| @@ -134,6 +135,20 @@ export class ChtApi { | |||
| return this.axiosInstance.post(url, deactivationPayload); | |||
| }; | |||
|
|
|||
| countContactsUnderPlace = async (docId: string): Promise<number> => { | |||
| const url = `medic/_design/medic/_view/contacts_by_depth`; | |||
| console.log('axios.get', url); | |||
There was a problem hiding this comment.
Why are we logging a constant? Do we wish to keep it for a while?
There was a problem hiding this comment.
I personally like seeing when the server makes requests to CHT, so all outbound requests from this cht-api library are logged. Fred has also indicated that he didn't like this pattern, but for now I'll stay consistent with the file and we can remove everywhere if we wish to remove.
src/services/hierarchy-view-model.ts
Outdated
| export function hierarchyViewModel(action: string, contactType: ContactType) { | ||
| const parentTypeName = contactType.hierarchy.find(h => h.level === 1)?.contact_type; | ||
| if (!parentTypeName) { | ||
| throw Error('parent type name'); |
There was a problem hiding this comment.
| throw Error('parent type name'); | |
| throw Error('Parent type name not found in contact type hierarchy'); |
Co-authored-by: Binod Adhikary <[email protected]>
#232