fix: getWarningInfo test #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inromualdo
reviewed
Jan 6, 2025
| @@ -146,9 +146,25 @@ describe('lib/manage-hierarchy.ts', () => { | |||
| }); | |||
|
|
|||
| describe('getWarningInfo', () => { | |||
| let clock; | |||
There was a problem hiding this comment.
@paulpascal , this will fix the tests, but it will be different in the app. Is it ok like that? If not, I will suggest to move to another library for the relatives... javascript-time-ago is used here...
What do you think?
There was a problem hiding this comment.
Thanks @inromualdo - Yes you are right this will only fix the test, lets handle that properly in another PR.
cc: @kennsippell
inromualdo
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #238, The tests would sometimes fail due to Luxon’s behavior of adjusting the date context based on the system’s current date.
To resolve this, we mocked the system clock in the test setup to ensure a fixed middle date (June 15, 2024) for consistent relative date calculations. This prevents test failures caused by discrepancies between the actual system date and the expected relative descriptions.