Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish only when merging to master #4

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Publish only when merging to master #4

merged 1 commit into from
Jan 11, 2024

Conversation

kennsippell
Copy link
Member

No description provided.

mrjones-plip
mrjones-plip approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks kenn! good call.

As well, we should see what how other repose that push to ECR protect against a build to a version that's already published (eg we have two or three versions of 1.0.0 on ECR now )

@kennsippell kennsippell merged commit bf587ff into main Jan 11, 2024
@kennsippell kennsippell deleted the publish-main-only branch January 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjones-plip mrjones-plip mrjones-plip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennsippell @mrjones-plip