Add UI directive, progress bar, and status counts #56
Conversation
|
Demo'ed and tested these UI changes it looks great and work for me @freddieptf @kennsippell |
src/public/place/directive.html
Outdated
| <div class="hero-body"> | ||
| {% if progress.inProgressCount > 0 %} | ||
| {% include "place/directive_3_in_progress.html" %} | ||
| {% elsif progress.successCount > 0 %} |
There was a problem hiding this comment.
We should show the upload prompt anytime we have anything staged
There was a problem hiding this comment.
In the nav bar or in this "directive" page? If we are showing it all the time, I'm inclined to use the navbar.
There was a problem hiding this comment.
In the directive, if we upload successfully we get the download prompt. If we stage new changes after the initial upload, I'd expect the download prompt to change to the upload prompt again
There was a problem hiding this comment.
ok. i have made the change as suggested. i thought you wanted to show both at once if there were complete ones + staged ones...
what if you upload 300 new users and there are 3 failures? should users see upload, download, or something else?
There was a problem hiding this comment.
I think download with an option to retry failed works in that case
There was a problem hiding this comment.
Can we have consistent header sizes and spacing with the views that already exist on the page? I also find the shadow/elevation on the boxes unnecessary
There was a problem hiding this comment.
Can we have consistent header sizes and spacing with the views that already exist on the page?
Sorry, I don't know what this means. Would you clarify?
There was a problem hiding this comment.
I also find the shadow/elevation on the boxes unnecessary
This is what the UI looks like without boxes. I don't particularly like this because nothing is aligned. I find there is no line to the page.
I'm currently using the default box control from Bulma. Can I ask what you would like to see? Are you thinking no boxes (above) or less elevated boxes? Happy to implement, but I'm really bad at design and need a little more input to make your dream a reality.
There was a problem hiding this comment.
I meant the headers in the directives are super huge compared to the other headers on the page. I find the elevation weird because it's makes the boxes a level higher than the navbar. Also the two boxes don't share the same background color. It's not a blocker so we can keep it and get a designer to have a look
There was a problem hiding this comment.
Capturing in #67 to get a designer to look at this. For now I'll reduce header size, match background color, remove elevation, and send another screenshot.
There was a problem hiding this comment.
it looks better the way it was before
User is now greeted with a default "Getting Started" message
Once you have a user staged and ready for creation, the next step is clear
When user uploads, they see a progress bar
Once they upload, they are prompted to save the credentials
In a future change, the tags on the rigth side can be updated to be used as filters. #61
Progress bar in #18
In response to, but not a fix for #53
Closes #64