Update klipfolio DS script's https use to work with node 11 & 12. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script to check if Klipfolio data sources are refreshing was breaking when run in node 11+. Turns out this is as a result of the http/s module using the URL object to parse the url and for some reason breaking basic auth with username & password set in the url string. Setting the auth detail in the options object and as a result leaving it to `https.get` to compose the url, fixes it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script to check if Klipfolio data sources are refreshing was
breaking when run in node 11+. Turns out this is as a result
of the http/s module using the URL object to parse
the url and for some reason breaking basic auth with username &
password set in the url string.
Setting the auth detail in the options object and as a result leaving
it to
https.getto compose the url, fixes it!