Add validation for start_row in pager.rb #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that unintended rows were retrieved when a value larger than sheets_max was specified for start_row.
bug details
When creating a spreadsheet with one row and two columns (see screenshot) and executing the plugin with start_row: 2 specified in config.yml, get_spreadsheet_values is executed for the range of
A2:B1.The
A2:B1range here is interpreted by the Google API in the same way asA1:B1, and[["ID", "value"]is obtained.Similarly, if you create a spreadsheet with 3 rows and 2 columns (see screenshot) and run the plugin with start_row: 4 in config.yml, get_spreadsheet_values to the range of
A4:B3is executed and[["2", "second value"]]is obtained.