refactor: add icon colors in textfield theme #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @medly-components/core, @medly-components/forms, @medly-components/theme BREAKING CHANGE: textfield theme needs to be updated to include the icon theme
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c843ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
affects: @medly-components/core
affects: @medly-components/core
affects: @medly-components/core, @medly-components/theme
affects: @medly-components/core, @medly-components/theme
affects: @medly-components/core
affects: @medly-components/core
affects: @medly-components/core, @medly-components/forms, @medly-components/theme
gmukul01
force-pushed
the
refactor-textfield
branch
from
14ad0e9
to
f94d844
Compare
affects: @medly-components/core
affects: @medly-components/core, @medly-components/forms
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @medly-components/core, @medly-components/forms, @medly-components/theme
BREAKING CHANGE:
textfield theme needs to be updated to include the icon theme
Description
Extract the icon colors as separate colors in TextField component.
Type of change
How has this been tested?
Updated the existing unit test cases.
Fixes #<issue_number>
What is the current behaviour?
Right now we are using label color for icon color
What is the new behaviour?
Add new values in the theme to color the icon in textField component.
Does this PR introduce a breaking change?
Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)
Additional context
(Replace This Text: Please describe any other related information or add screenshots of the PR.)
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules