Skip to content

Commit

Permalink
fix(product): change export name of ProductImage (#10326)
Browse files Browse the repository at this point in the history
Change export of `Image` to `ProductImage` to match the data model's name.
  • Loading branch information
shahednasser authored Nov 27, 2024
1 parent 030b0cc commit 2838100
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/purple-maps-bow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@medusajs/product": patch
---

fix(product): change export name of ProductImage
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
} from "@medusajs/framework/utils"
import { SqlEntityManager } from "@mikro-orm/postgresql"
import {
Image,
ProductImage,
Product,
ProductCategory,
ProductCollection,
Expand Down Expand Up @@ -133,7 +133,7 @@ export async function createImages(
imagesData: string[]
) {
const images: any[] = imagesData.map((img) => {
return manager.create(toMikroORMEntity(Image), { url: img })
return manager.create(toMikroORMEntity(ProductImage), { url: img })
})

await manager.persistAndFlush(images)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
ProductStatus,
} from "@medusajs/framework/utils"
import {
Image,
ProductImage,
Product,
ProductCategory,
ProductCollection,
Expand Down Expand Up @@ -1345,17 +1345,17 @@ moduleIntegrationTestRunner<IProductModuleService>({
const manager = MikroOrmWrapper.forkManager()

const images = [
manager.create(Image, {
manager.create(ProductImage, {
product_id: product.id,
url: "image-one",
rank: 1,
}),
manager.create(Image, {
manager.create(ProductImage, {
product_id: product.id,
url: "image-two",
rank: 0,
}),
manager.create(Image, {
manager.create(ProductImage, {
product_id: product.id,
url: "image-three",
rank: 2,
Expand Down
2 changes: 1 addition & 1 deletion packages/modules/product/src/models/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export { default as Product } from "./product"
export { default as ProductCategory } from "./product-category"
export { default as ProductCollection } from "./product-collection"
export { default as Image } from "./product-image"
export { default as ProductImage } from "./product-image"
export { default as ProductOption } from "./product-option"
export { default as ProductOptionValue } from "./product-option-value"
export { default as ProductTag } from "./product-tag"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
Product,
ProductCategory,
ProductCollection,
Image as ProductImage,
ProductImage,
ProductOption,
ProductOptionValue,
ProductTag,
Expand Down

0 comments on commit 2838100

Please sign in to comment.