fix: Use sub instead of email for google entity ID (#9949)

medusajs · Nov 7, 2024 · cd578e8 · cd578e8
1 parent 242d00b
commit cd578e8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/.changeset/beige-dots-divide.md b/.changeset/beige-dots-divide.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/auth-google": patch
+---
+
+fix: Use sub instead of email for google entity ID
diff --git a/packages/modules/providers/auth-google/integration-tests/__tests__/services.spec.ts b/packages/modules/providers/auth-google/integration-tests/__tests__/services.spec.ts
@@ -155,7 +155,7 @@ describe("Google auth provider", () => {
         return {
           provider_identities: [
             {
-              entity_id: "[email protected]",
+              entity_id: "113664482950786663866",
               provider: "google",
             },
           ],
@@ -180,7 +180,7 @@ describe("Google auth provider", () => {
       authIdentity: {
         provider_identities: [
           {
-            entity_id: "[email protected]",
+            entity_id: "113664482950786663866",
             provider: "google",
           },
         ],
@@ -194,7 +194,7 @@ describe("Google auth provider", () => {
         return {
           provider_identities: [
             {
-              entity_id: "[email protected]",
+              entity_id: "113664482950786663866",
               provider: "google",
             },
           ],
@@ -222,7 +222,7 @@ describe("Google auth provider", () => {
       authIdentity: {
         provider_identities: [
           {
-            entity_id: "[email protected]",
+            entity_id: "113664482950786663866",
             provider: "google",
           },
         ],

diff --git a/packages/modules/providers/auth-google/src/services/google.ts b/packages/modules/providers/auth-google/src/services/google.ts
@@ -142,8 +142,7 @@ export class GoogleAuthService extends AbstractAuthModuleProvider {
       )
     }
 
-    // TODO: We should probably use something else than email here, like the `sub` field (which is more constant than the email)
-    const entity_id = payload.email
+    const entity_id = payload.sub
     const userMetadata = {
       name: payload.name,
       picture: payload.picture,