Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update Repository Directory Paths for All Packages #10910

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

rahul-rocket
Copy link

@rahul-rocket rahul-rocket commented Jan 10, 2025

This PR updates the repository.directory field in the package.json files of all packages to include the correct directory paths, reflecting the structure within the Medusa repository.

Changes:

  • Updated the repository.directory paths for all packages to include the modules folder where applicable.

Example: "directory": "packages/api-key" was changed to "directory": "packages/modules/api-key".

This ensures accurate references to the package locations within the repository for better clarity and maintainability. Please review and merge.

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 134d257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 10, 2025

@rahul-rocket is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@sradevski
Copy link
Member

@rahul-rocket actually the path is packages/modules/providers/file-s3, but most of the folders haven't been updated. Maybe you can just update all references to be correct in one go?

@rahul-rocket
Copy link
Author

rahul-rocket commented Jan 11, 2025

@rahul-rocket actually the path is packages/modules/providers/file-s3, but most of the folders haven't been updated. Maybe you can just update all references to be correct in one go?

@sradevski Yes, I can fix all those paths in this single PR. Let me work on it.

This PR updates the `repository.directory` field in the `package.json` files for packages located within the `modules` folder.

### Changes:
- Added the `modules` prefix to the `directory` path in the `repository` field for all affected `package.json` files.
  - Example: `"directory": "packages/event-bus-local"` was changed to `"directory": "packages/modules/event-bus-local"`.
@rahul-rocket rahul-rocket requested a review from a team as a code owner January 11, 2025 05:42
@rahul-rocket rahul-rocket changed the title [Fix] Update Repository Directory to "packages/file-s3" [Fix] Update Repository Directory Paths for All Packages Jan 11, 2025
@rahul-rocket
Copy link
Author

@sradevski I made the changes as you suggested. Could you please review the PR and let me know if you would like any further modifications? Thanks!

Best regards,
Rahul Rathore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants