Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Update Repository Directory Paths for All Packages #10910

Merged
merged 5 commits into from
Jan 13, 2025
Merged

[Fix] Update Repository Directory Paths for All Packages #10910

merged 5 commits into from
Jan 13, 2025

Conversation

rahul-rocket
Copy link
Contributor

@rahul-rocket rahul-rocket commented Jan 10, 2025 •
edited
Loading

This PR updates the repository.directory field in the package.json files of all packages to include the correct directory paths, reflecting the structure within the Medusa repository.

Changes:

  • Updated the repository.directory paths for all packages to include the modules folder where applicable.

Example: "directory": "packages/api-key" was changed to "directory": "packages/modules/api-key".

This ensures accurate references to the package locations within the repository for better clarity and maintainability. Please review and merge.

@rahul-rocket rahul-rocket requested a review from a team as a code owner January 10, 2025 13:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3080a0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025

@rahul-rocket is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@sradevski
Copy link
Member

@rahul-rocket actually the path is packages/modules/providers/file-s3, but most of the folders haven't been updated. Maybe you can just update all references to be correct in one go?

@rahul-rocket
Copy link
Contributor Author

rahul-rocket commented Jan 11, 2025 •
edited
Loading

@rahul-rocket actually the path is packages/modules/providers/file-s3, but most of the folders haven't been updated. Maybe you can just update all references to be correct in one go?

@sradevski Yes, I can fix all those paths in this single PR. Let me work on it.

@rahul-rocket rahul-rocket requested a review from a team as a code owner January 11, 2025 05:42
@rahul-rocket rahul-rocket changed the title [Fix] Update Repository Directory to "packages/file-s3" [Fix] Update Repository Directory Paths for All Packages Jan 11, 2025
@rahul-rocket
Copy link
Contributor Author

@sradevski I made the changes as you suggested. Could you please review the PR and let me know if you would like any further modifications? Thanks!

Best regards,
Rahul Rathore

sradevski
sradevski approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please rebase and we'll have it merged

@rahul-rocket
fix: update repository directory to "packages/file-s3" in package.json
9c4edd5
@rahul-rocket
fix: update directory paths for packages inside modules folder
5ae09bc 
This PR updates the `repository.directory` field in the `package.json` files for packages located within the `modules` folder.

### Changes:
- Added the `modules` prefix to the `directory` path in the `repository` field for all affected `package.json` files.
  - Example: `"directory": "packages/event-bus-local"` was changed to `"directory": "packages/modules/event-bus-local"`.
@rahul-rocket
chore: add /packages/**/.cache folder to .gitignore
e770620
@rahul-rocket
fix: update directory paths for packages inside packages/core folder
062cf55
@rahul-rocket
fix: update directory paths for packages inside packages/cli folder
3080a0a
@rahul-rocket
Copy link
Contributor Author

Looks good, thanks! Please rebase and we'll have it merged

Done @sradevski

@sradevski sradevski merged commit ecf7378 into medusajs:develop Jan 13, 2025
14 of 22 checks passed
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@rahul-rocket @noubase
[Fix] Update Repository Directory Paths for All Packages (medusajs#10910
cc071e2 
)

This PR updates the `repository.directory` field in the `package.json` files for packages located within the `modules` folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@sradevski sradevski sradevski approved these changes

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-rocket @sradevski @adrien2p