Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add actor type check + more tests #10005

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@olivermrbl olivermrbl requested a review from a team as a code owner November 10, 2024 13:03
Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 1:03pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 10, 2024 1:03pm
api-reference-v2 ⬜️ Ignored (Inspect) Nov 10, 2024 1:03pm
docs-ui ⬜️ Ignored (Inspect) Nov 10, 2024 1:03pm
docs-v2 ⬜️ Ignored (Inspect) Nov 10, 2024 1:03pm
medusa-docs ⬜️ Ignored (Inspect) Nov 10, 2024 1:03pm
resources-docs ⬜️ Ignored (Inspect) Nov 10, 2024 1:03pm

Copy link

changeset-bot bot commented Nov 10, 2024

⚠️ No Changeset found

Latest commit: 1f5accc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -43,15 +43,15 @@ export class EmailPassAuthService extends AbstractAuthModuleProvider {
}

async update(
data: { email: string; password: string },
data: { password: string; entity_id: string },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently only allow password updates, this could possibly be extended in the future.

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 0949717 into develop Nov 10, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/further-updates-to-auth branch November 10, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants