Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: pluralize type helper to account for uncountable nouns and special rules #10011

Merged
merged 3 commits into from
Nov 11, 2024
Merged

breaking: pluralize type helper to account for uncountable nouns and special rules #10011

merged 3 commits into from
Nov 11, 2024

Conversation

thetutlage
Copy link
Contributor

@thetutlage thetutlage commented Nov 11, 2024 •
edited
Loading

Fixes: FRMW-2771

This PR updates the Pluralize type helper to have two conditional checks when converting a singular value to plural at types level.

  • First, it checks for uncountable nouns in a dictionary.
  • Second, it looks for special rules for certain words like tooth, man and so on.

This change will make us more compatible with the runtime behavior of pluralizing values. However, things won't be in 100% sync yet.

@thetutlage thetutlage requested a review from a team as a code owner November 11, 2024 09:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 52cf915

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 11:05am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 11, 2024 11:05am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:05am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:05am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:05am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:05am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:05am

@thetutlage thetutlage mentioned this pull request Nov 11, 2024
Closed
@thetutlage thetutlage changed the title fix: pluralize type helper to account for uncountable nouns and special rules breaking: pluralize type helper to account for uncountable nouns and special rules Nov 11, 2024
olivermrbl
olivermrbl approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thetutlage thetutlage merged commit e228088 into develop Nov 11, 2024
23 checks passed
@thetutlage thetutlage deleted the fix/plural-type-helper branch November 11, 2024 11:50
thetutlage added a commit that referenced this pull request Nov 11, 2024
@thetutlage
docs: add changeset for #10011
4dd234e
@thetutlage thetutlage mentioned this pull request Nov 11, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 11, 2024
@thetutlage
docs: add changeset for #10011 (#10018)
bc2d556 
Missed changeset in this PR #10011.

Trying to get into the habit of creating one 🙏
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
has: breaking changes team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thetutlage @olivermrbl