Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass color to github icon #10013

Closed
wants to merge 1 commit into from
Closed

Conversation

christiananese
Copy link
Contributor

No description provided.

@christiananese christiananese requested a review from a team as a code owner November 11, 2024 10:02
Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 3aa1e19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:03am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:03am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Nov 11, 2024 10:03am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 10:03am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 10:03am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 10:03am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 10:03am

@kasperkristensen
Copy link
Contributor

@christiananese the icons package is autogenerated so you shouldn't make changes to the files as it will just be overwritten the next time I run the script to update icons. And all "brand" icons have fixed colors by design, you can ask Ludvig to add a GITHUB-EX icon to the Medusa UI Figma file, which will result in a icon that allows changing the color being generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants