Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(workflows-sdk): Display each error individually instead of packed #10072

Merged
merged 3 commits into from
Nov 15, 2024
Merged

chore(workflows-sdk): Display each error individually instead of packed #10072

merged 3 commits into from
Nov 15, 2024

Conversation

adrien2p
Copy link
Member

What
Instead of displaying a single string prepared with all the errors, log each error individually

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 8:05am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 8:05am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 8:05am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 8:05am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 8:05am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 8:05am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 8:05am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb10bb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review November 14, 2024 13:16
@adrien2p adrien2p requested a review from a team as a code owner November 14, 2024 13:16
@kodiakhq kodiakhq bot merged commit 10da8b3 into develop Nov 15, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the chore/workflow-log-on-error-display branch November 15, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski sradevski approved these changes

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien2p @sradevski @olivermrbl