Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename workflow to singular #10134

Merged
merged 2 commits into from
Nov 18, 2024
Merged

refactor: rename workflow to singular #10134

merged 2 commits into from
Nov 18, 2024

Conversation

thetutlage
Copy link
Contributor

@thetutlage thetutlage commented Nov 18, 2024 •
edited
Loading

Deprecated the createOrdersWorkflow and exported a new workflow with singular name.

The deprecated method will appear as follows.

CleanShot 2024-11-18 at 14 33 33@2x

Changeset is in - #10136

@thetutlage thetutlage requested a review from a team as a code owner November 18, 2024 06:42
@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:21am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 18, 2024 8:21am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 8:21am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 8:21am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 8:21am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 8:21am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 8:21am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d1a036

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this route to use it? packages/medusa/src/api/admin/draft-orders/route.ts

@thetutlage thetutlage merged commit 2c957c6 into develop Nov 18, 2024
23 checks passed
@thetutlage thetutlage deleted the refactor/rename-order-workflow branch November 18, 2024 09:28
@thetutlage thetutlage restored the refactor/rename-order-workflow branch November 18, 2024 09:31
@thetutlage thetutlage mentioned this pull request Nov 18, 2024
Merged
@thetutlage thetutlage deleted the refactor/rename-order-workflow branch November 18, 2024 10:08
@sradevski sradevski mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@mrnbpt mrnbpt Awaiting requested review from mrnbpt mrnbpt is a code owner automatically assigned from medusajs/engineering

@shahednasser shahednasser Awaiting requested review from shahednasser

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thetutlage @carlos-r-l-rodrigues @olivermrbl