Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): updated variant title is used when creating product #10155

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Nov 19, 2024

what:

When editing titles for product variants in the bulk editor form, the new titles were not being picked up during create product api call due to incorrect attribute being picked for variant title. This PR fixes uses variant.title instead of variant.custom_title to fix this issue.

RESOLVES SUP-218

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 0:06am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 19, 2024 0:06am
api-reference-v2 ⬜️ Ignored (Inspect) Nov 19, 2024 0:06am
docs-ui ⬜️ Ignored (Inspect) Nov 19, 2024 0:06am
docs-v2 ⬜️ Ignored (Inspect) Nov 19, 2024 0:06am
medusa-docs ⬜️ Ignored (Inspect) Nov 19, 2024 0:06am
resources-docs ⬜️ Ignored (Inspect) Nov 19, 2024 0:06am

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: bf0885b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan merged commit 2783bed into develop Nov 19, 2024
24 checks passed
@riqwan riqwan deleted the fix/variant-title branch November 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants