Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stripe): Wrong container type #10223

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 22, 2024

RESOLVES SUP-238

What

wrong container type withing payment providers

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: fb221cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:41am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 22, 2024 10:41am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 10:41am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 10:41am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 10:41am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 10:41am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 10:41am

@adrien2p adrien2p changed the title chore(orchestration): Allow workflow execution using a cradle for the container fix(stripe): Wrong container type Nov 22, 2024
@adrien2p adrien2p marked this pull request as ready for review November 22, 2024 09:50
@adrien2p adrien2p requested a review from a team as a code owner November 22, 2024 09:50
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought(non-blocking): Should we rename containers to cradle in the provider interfaces, abstract classes, and classes? Perhaps, this would make the access pattern even more obvious.

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien2p
Copy link
Member Author

thought(non-blocking): Should we rename containers to cradle in the provider interfaces, abstract classes, and classes? Perhaps, this would make the access pattern even more obvious.

yes that might be better indeed, let me change that

@adrien2p
Copy link
Member Author

adrien2p commented Nov 22, 2024

@olivermrbl are you fine if I just change the name in the constructor but not the class prop as it would create a breaking change?

@olivermrbl
Copy link
Contributor

Yes, sure, makes sense to me.

@kodiakhq kodiakhq bot merged commit b964b45 into develop Nov 22, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the chore/improve-local-workflow-with-cradle branch November 22, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants