-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stripe): Wrong container type #10223
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought(non-blocking): Should we rename containers to cradle
in the provider interfaces, abstract classes, and classes? Perhaps, this would make the access pattern even more obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yes that might be better indeed, let me change that |
@olivermrbl are you fine if I just change the name in the constructor but not the class prop as it would create a breaking change? |
Yes, sure, makes sense to me. |
RESOLVES SUP-238
What
wrong container type withing payment providers