Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/js-sdk) Add the credentials field in the fetch() only if supported #10445

Closed

Conversation

sgirones
Copy link
Contributor

@sgirones sgirones commented Dec 5, 2024

solves medusajs/nextjs-starter-medusa#421

The root cause of the issue is that credentials is not supported by CloudFlare workers.

@sgirones sgirones requested a review from a team as a code owner December 5, 2024 09:35
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 8b499cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 9:38am

Copy link

vercel bot commented Dec 5, 2024

@sgirones is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@sgirones
Copy link
Contributor Author

sgirones commented Dec 5, 2024

/snapshot-this

Copy link
Contributor

github-actions bot commented Dec 5, 2024

/snapshot-this is not supported on pull requests from forked repositories.

@sgirones
Copy link
Contributor Author

sgirones commented Dec 5, 2024

closing in favour of #10446

@sgirones sgirones closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant