Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): add missing query type argument in request types #10456

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

shahednasser
Copy link
Member

We recently added support for specifying query type arguments in MedusaRequest. This adds the type argument to AuthenticatedMedusaRequest and MedusaStoreRequest, to be passed to MedusaRequest

SIde note: it doesn't seem like MedusaStoreRequest is used anywhere, not sure why we have it.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 2:54pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 5, 2024 2:54pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:54pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:54pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:54pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:54pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:54pm

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 6e0d025

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/framework Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
integration-tests-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shahednasser shahednasser merged commit 597bffa into develop Dec 6, 2024
23 checks passed
@shahednasser shahednasser deleted the fix/query-request-type-arg branch December 6, 2024 07:53
hirotaka pushed a commit to hirotaka/medusa that referenced this pull request Dec 7, 2024
…usajs#10456)

* fix(framework): add missing query type argument in request types

* fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants