feat(core-flows,dashboard,js-sdk,medusa,types): support Fulfillment Options #10622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
…shipping method create
fPolic
force-pushed
the
feat/list-fulfillment-options
branch
from
30d0243 to
45869f7
Compare
fPolic
requested review from
sgirones,
carlos-r-l-rodrigues,
kasperkristensen and
olivermrbl
olivermrbl
reviewed
Dec 17, 2024
packages/medusa/src/api/admin/fulfillment-providers/[id]/options/route.ts
Show resolved
Hide resolved
...-service-zone-shipping-option-edit/components/edit-region-form/edit-shipping-option-form.tsx
Outdated
Show resolved
Hide resolved
...pping-option-create/components/create-shipping-options-form/create-shipping-options-form.tsx
Show resolved
Hide resolved
olivermrbl
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Overall LGTM, one final comment.
@kasperkristensen, if you could find time to glance over the UI, that would be great :)
packages/core/core-flows/src/cart/workflows/add-shipping-method-to-cart.ts
Outdated
Show resolved
Hide resolved
kasperkristensen
approved these changes
Dec 18, 2024
...ption-create/components/create-shipping-options-form/create-shipping-option-details-form.tsx
Outdated
Show resolved
Hide resolved
noubase
pushed a commit
to noubase/medusa
that referenced
this pull request
Jan 22, 2025
…ptions (medusajs#10622) **What** - add a list point for fetching fulfillment options for a provider - add FO support on SO create & update on dashboard - pass `cart` and `stockLocation` to `validateFufillmentData` context --- CLOSES CMRC-789 CLOSES CMRC-790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
cartandstockLocationtovalidateFufillmentDatacontextCLOSES CMRC-789
CLOSES CMRC-790