Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-bundler,admin-vite-plugin,medusa): Add support for loading Admin Extensions from plugins #10869

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Jan 7, 2025

Should not be merged before #10895

What

  • Introduces a new plugin command to admin-bundler, currently not used anywhere but will be called from medusa build:plugin
  • Discovers plugins with extensions and add passes the to admin-vite-plugin.
  • Updates admin-vite-plugin so its able to read built admin extensions.

Resolves CMRC-830, CMRC-839

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: f5eccef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/admin-vite-plugin Patch
@medusajs/admin-bundler Patch
@medusajs/medusa Patch
@medusajs/dashboard Patch
integration-tests-http Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 0:36am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 10, 2025 0:36am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:36am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:36am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:36am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:36am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:36am

@kasperkristensen kasperkristensen marked this pull request as ready for review January 8, 2025 14:10
@kasperkristensen kasperkristensen requested a review from a team as a code owner January 8, 2025 14:10
@kasperkristensen kasperkristensen changed the title feat(admin-bundler,admin-vite-plugin): Add support for loading Admin Extensions from plugins feat(admin-bundler,admin-vite-plugin,medusa): Add support for loading Admin Extensions from plugins Jan 9, 2025
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looping in @medusajs/framework in case they want to have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants