Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore:workflow sdk cleanup #9654

Closed
wants to merge 29 commits into from
Closed

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 18, 2024

What
First stab at migrating the workflows-sdk, some refactoring of the method implementation are left for a separate work. The idea of this PR is mainly reorganising the logic and make it easier to change and evolve while adding some implementations improvements

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 8:33pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 3, 2024 8:33pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 8:33pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 8:33pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 8:33pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 8:33pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 8:33pm

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 1a89426

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p
Copy link
Member Author

@olivermrbl I ve managed the backward compatibility API to not have any breaking changes. I still have one thing to figure out for the typings in one place and then we can think about merging. I put it on pause for now

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 15, 2025
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants