-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored logger internals #3428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging. |
lminiero
added a commit
that referenced
this pull request
Oct 11, 2024
spscream
pushed a commit
to spscream/janus-gateway
that referenced
this pull request
Oct 24, 2024
natikaltura
pushed a commit
to natikaltura/janus-gateway
that referenced
this pull request
Nov 7, 2024
mwalbeck
pushed a commit
to mwalbeck/docker-janus-gateway
that referenced
this pull request
Nov 28, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [meetecho/janus-gateway](https://github.com/meetecho/janus-gateway) | minor | `v1.2.4` -> `v1.3.0` | --- ### Release Notes <details> <summary>meetecho/janus-gateway (meetecho/janus-gateway)</summary> ### [`v1.3.0`](https://github.com/meetecho/janus-gateway/blob/HEAD/CHANGELOG.md#v130---2024-11-25) [Compare Source](meetecho/janus-gateway@v1.2.4...v1.3.0) - Refactored logging internals \[[PR-3428](meetecho/janus-gateway#3428)] - Use strtok to parse SDPs \[[PR-3424](meetecho/janus-gateway#3424)] - Fixed rare condition that could lead to a deadlock in the VideoRoom \[[PR-3446](meetecho/janus-gateway#3446)] - Fixed broken switch when using remote publishers in VideoRoom \[[PR-3447](meetecho/janus-gateway#3447)] - Added SRTP support to VideoRoom remote publishers (thanks [@​spscream](https://github.com/spscream)!) \[[PR-3449](meetecho/janus-gateway#3449)] - Added support for generic JSON metadata to VideoRoom publishers (thanks [@​spscream](https://github.com/spscream)!) \[[PR-3467](meetecho/janus-gateway#3467)] - Fixed deadlock in VideoRoom when failing to open a socket for a new RTP forwarder (thanks [@​spscream](https://github.com/spscream)!) \[[PR-3468](meetecho/janus-gateway#3468)] - Fixed deadlock in VideoRoom caused by reverse ordering of mutex locks \[[PR-3474](meetecho/janus-gateway#3474)] - Fixed memory leaks when using remote publishers in VideoRoom \[[PR-3475](meetecho/janus-gateway#3475)] - Diluted frequency of PLI in the VideoRoom (thanks [@​natikaltura](https://github.com/natikaltura)!) \[[PR-3423](meetecho/janus-gateway#3423)] - Better cleanup after failed mountpoint creations in Streaming plugin \[[PR-3465](meetecho/janus-gateway#3465)] - Fixed compilation of AudioBridge in case libogg isn't available (thanks [@​tmatth](https://github.com/tmatth)!) \[[PR-3438](meetecho/janus-gateway#3438)] - Better management of call cleanup in SIP plugin \[[Issue-3430](meetecho/janus-gateway#3430)] - Change the way call-IDs are tracked in the SIP plugin (thanks WebTrit!) \[[PR-3443](meetecho/janus-gateway#3443)] - Increased maximum size of custom SIP headers \[[Issue-3459](meetecho/janus-gateway#3459)] - Other smaller fixes and improvements (thanks to all who contributed pull requests and reported issues!) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzkuMjguMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Reviewed-on: https://git.walbeck.it/walbeck-it/docker-janus-gateway/pulls/157 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a static code analysis with Coverity last week, and the issue opened in #3427, we decided to try and refactor the way logging is performed internally, which is what this PR does.
Rather than using growing and reusable buffers as before, we switched to an async queue with smaller allocations for each item passed to the logger. While this increases the number of allocations, it's much more thread safe than before: fixing the broken behaviour the old code could have (and in practice pretty much never had, except for rare occurrences like the issue above) would have meant expanding the scope of the existing mutexes, which could have risked bottlenecks in potentially critical parts of the code (we definitely don't want queueing something for the logs to wait).
I took advantage of this refactoring to also fix another sometimes inconsistent behaviour, that is some initial lines that would always be missing when using log files or external loggers. The new queueing mechanism now takes that into account.
We performed some stress testing and comparisons, and apparently the new approach is slightly faster in the tests we made. Please do test the PR, especially if you have "chatty" Janus instances, and let us know if you encounter any issues before we merge this. It's a PR for
master
, at the moment, but I'll backport it to0.x
too when done.