Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audiobridge: fix building without libogg #3438

Merged
merged 2 commits into from
Sep 30, 2024
Merged

audiobridge: fix building without libogg #3438

merged 2 commits into from
Sep 30, 2024

Conversation

tmatth
Copy link
Contributor

@tmatth tmatth commented Sep 29, 2024

Fixes #3436

@tmatth tmatth mentioned this pull request Sep 29, 2024
Closed
@tmatth
Copy link
Contributor Author

tmatth commented Sep 29, 2024 •
edited
Loading

N.B. Haven't had a chance to test this yet. Also not sure if it's better to attach an empty list of announcements (as I'm doing here) or skip the field altogether.

lminiero
lminiero reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@lminiero lminiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just added a note inline.

src/plugins/janus_audiobridge.c Outdated Show resolved Hide resolved
@lminiero
Copy link
Member

Thanks, merging! I'll cherry pick for 0.x too.

@lminiero lminiero merged commit fb9c2cc into meetecho:master Sep 30, 2024
8 checks passed
lminiero pushed a commit that referenced this pull request Sep 30, 2024
@tmatth @lminiero
audiobridge: fix building without libogg (#3438)
5b0dfd6 
* audiobridge: fix build without libogg
* audiobridge: fix warnings without libogg
natikaltura pushed a commit to natikaltura/janus-gateway that referenced this pull request Nov 7, 2024
@tmatth @natikaltura
audiobridge: fix building without libogg (meetecho#3438)
e20d19c 
* audiobridge: fix build without libogg
* audiobridge: fix warnings without libogg
mwalbeck pushed a commit to mwalbeck/docker-janus-gateway that referenced this pull request Nov 28, 2024
@mwalbeck
Update dependency meetecho/janus-gateway to v1.3.0 (#157)
3a8b712 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [meetecho/janus-gateway](https://github.com/meetecho/janus-gateway) | minor | `v1.2.4` -> `v1.3.0` |

---

### Release Notes

<details>
<summary>meetecho/janus-gateway (meetecho/janus-gateway)</summary>

### [`v1.3.0`](https://github.com/meetecho/janus-gateway/blob/HEAD/CHANGELOG.md#v130---2024-11-25)

[Compare Source](meetecho/janus-gateway@v1.2.4...v1.3.0)

-   Refactored logging internals \[[PR-3428](meetecho/janus-gateway#3428)]
-   Use strtok to parse SDPs \[[PR-3424](meetecho/janus-gateway#3424)]
-   Fixed rare condition that could lead to a deadlock in the VideoRoom \[[PR-3446](meetecho/janus-gateway#3446)]
-   Fixed broken switch when using remote publishers in VideoRoom \[[PR-3447](meetecho/janus-gateway#3447)]
-   Added SRTP support to VideoRoom remote publishers (thanks [@&#8203;spscream](https://github.com/spscream)!) \[[PR-3449](meetecho/janus-gateway#3449)]
-   Added support for generic JSON metadata to VideoRoom publishers (thanks [@&#8203;spscream](https://github.com/spscream)!) \[[PR-3467](meetecho/janus-gateway#3467)]
-   Fixed deadlock in VideoRoom when failing to open a socket for a new RTP forwarder (thanks [@&#8203;spscream](https://github.com/spscream)!) \[[PR-3468](meetecho/janus-gateway#3468)]
-   Fixed deadlock in VideoRoom caused by reverse ordering of mutex locks \[[PR-3474](meetecho/janus-gateway#3474)]
-   Fixed memory leaks when using remote publishers in VideoRoom \[[PR-3475](meetecho/janus-gateway#3475)]
-   Diluted frequency of PLI in the VideoRoom (thanks [@&#8203;natikaltura](https://github.com/natikaltura)!) \[[PR-3423](meetecho/janus-gateway#3423)]
-   Better cleanup after failed mountpoint creations in Streaming plugin \[[PR-3465](meetecho/janus-gateway#3465)]
-   Fixed compilation of AudioBridge in case libogg isn't available (thanks [@&#8203;tmatth](https://github.com/tmatth)!) \[[PR-3438](meetecho/janus-gateway#3438)]
-   Better management of call cleanup in SIP plugin \[[Issue-3430](meetecho/janus-gateway#3430)]
-   Change the way call-IDs are tracked in the SIP plugin (thanks WebTrit!) \[[PR-3443](meetecho/janus-gateway#3443)]
-   Increased maximum size of custom SIP headers \[[Issue-3459](meetecho/janus-gateway#3459)]
-   Other smaller fixes and improvements (thanks to all who contributed pull requests and reported issues!)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzkuMjguMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->

Reviewed-on: https://git.walbeck.it/walbeck-it/docker-janus-gateway/pulls/157
Co-authored-by: renovate-bot <[email protected]>
Co-committed-by: renovate-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lminiero lminiero lminiero left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.x]janus_audiobridge_participant’ has no member named ‘annc
2 participants
@tmatth @lminiero