-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata for videoroom publishers #3467
Conversation
I've used display with stringified json before for exactly this purpose so it would be great to have a proper meta data field |
It does make sense, yes, but as it is it looks like it's an immutable object. I'd add an option to modify the metadata object in a configure request (and notify the change to other attendees), just as you can edit the display name dynamically. |
35f15cf
to
d3a1a0d
Compare
added ability to update metadata |
5e3bfa0
to
04f5886
Compare
Thanks for the changes, looks good to me! Once you fix the conflicts, I think this is ready to be merged. |
04f5886
to
d127f04
Compare
@lminiero rebased |
d127f04
to
8e7cd86
Compare
8e7cd86
to
520648e
Compare
Thanks! The only thing I'm wondering about, now, is that if you use a configure to update both |
Merging 👍 |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [meetecho/janus-gateway](https://github.com/meetecho/janus-gateway) | minor | `v1.2.4` -> `v1.3.0` | --- ### Release Notes <details> <summary>meetecho/janus-gateway (meetecho/janus-gateway)</summary> ### [`v1.3.0`](https://github.com/meetecho/janus-gateway/blob/HEAD/CHANGELOG.md#v130---2024-11-25) [Compare Source](meetecho/janus-gateway@v1.2.4...v1.3.0) - Refactored logging internals \[[PR-3428](meetecho/janus-gateway#3428)] - Use strtok to parse SDPs \[[PR-3424](meetecho/janus-gateway#3424)] - Fixed rare condition that could lead to a deadlock in the VideoRoom \[[PR-3446](meetecho/janus-gateway#3446)] - Fixed broken switch when using remote publishers in VideoRoom \[[PR-3447](meetecho/janus-gateway#3447)] - Added SRTP support to VideoRoom remote publishers (thanks [@​spscream](https://github.com/spscream)!) \[[PR-3449](meetecho/janus-gateway#3449)] - Added support for generic JSON metadata to VideoRoom publishers (thanks [@​spscream](https://github.com/spscream)!) \[[PR-3467](meetecho/janus-gateway#3467)] - Fixed deadlock in VideoRoom when failing to open a socket for a new RTP forwarder (thanks [@​spscream](https://github.com/spscream)!) \[[PR-3468](meetecho/janus-gateway#3468)] - Fixed deadlock in VideoRoom caused by reverse ordering of mutex locks \[[PR-3474](meetecho/janus-gateway#3474)] - Fixed memory leaks when using remote publishers in VideoRoom \[[PR-3475](meetecho/janus-gateway#3475)] - Diluted frequency of PLI in the VideoRoom (thanks [@​natikaltura](https://github.com/natikaltura)!) \[[PR-3423](meetecho/janus-gateway#3423)] - Better cleanup after failed mountpoint creations in Streaming plugin \[[PR-3465](meetecho/janus-gateway#3465)] - Fixed compilation of AudioBridge in case libogg isn't available (thanks [@​tmatth](https://github.com/tmatth)!) \[[PR-3438](meetecho/janus-gateway#3438)] - Better management of call cleanup in SIP plugin \[[Issue-3430](meetecho/janus-gateway#3430)] - Change the way call-IDs are tracked in the SIP plugin (thanks WebTrit!) \[[PR-3443](meetecho/janus-gateway#3443)] - Increased maximum size of custom SIP headers \[[Issue-3459](meetecho/janus-gateway#3459)] - Other smaller fixes and improvements (thanks to all who contributed pull requests and reported issues!) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzkuMjguMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Reviewed-on: https://git.walbeck.it/walbeck-it/docker-janus-gateway/pulls/157 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>
I want to introduce ability to set metadata for publishers on join.
I added metadata field with json_t and save info to it on join and send it in "joined"/"published" events.
We use it on our branch now to build custom business logic for videoroom, for example we set in metadata now: