janus-pp-rec: improve DTX detection #3488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves opus DTX detection in janus-pp-rec by considering as DTX those packets with a plen greater than 20 ms.
We are aware that WebRTC/opus supports plen up to 60ms, but historically janus-pp-rec has only been capable of processing 20ms packets so we're not introducing any regression from that perspective.
Since pp-rec restamping (
-r) artificially introduces larger timestamp gaps, we mark restamped packets in the first loop of janus-pp-rec in order not to confuse them with DTX packets.